Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive animation patterns reference document to the SwiftUI expert skill, covering property animations, transitions, phase-based animations, keyframe animations, and the Animatable protocol. The reference is integrated into the SKILL.md workflow for reviewing, improving, and implementing SwiftUI features.
Changes:
- Added
references/animation-patterns.mdwith detailed animation guidance covering implicit/explicit animations, transitions, iOS 17+ phase/keyframe APIs, and best practices - Updated SKILL.md to integrate animation pattern checks into the review, improve, and implement workflows
- Added animation checklist items and reference link to SKILL.md
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| swiftui-expert-skill/references/animation-patterns.md | New comprehensive reference covering SwiftUI animation patterns, transitions, timing curves, the Animatable protocol, phase-based animations (iOS 17+), keyframe animations (iOS 17+), best practices, and common pitfalls |
| swiftui-expert-skill/SKILL.md | Integrated animation-patterns.md into workflows (review/improve/implement), added Animation section to Core Guidelines, added animation checklist, and added reference link |
AvdLee
left a comment
AvdLee
left a comment
There was a problem hiding this comment.
Before continuing my review, I think it's good to add a BAD and GOOD example for all cases. This will strongly improve the impact of this skill reference file!
| .animation(.default, value: flag) | ||
| ``` | ||
|
|
||
| **Important:** Always use the value parameter (the version without it is deprecated). |
There was a problem hiding this comment.
How about adding a wrong example here with the deprecated code example?
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AvdLee
left a comment
AvdLee
left a comment
There was a problem hiding this comment.
Looks good to me, I actually like the separation and it makes total sense. Much better optimized. If you could look at the Copilot feedback, that would be great! After that, you can merge.
…kill into swiftui-animation
No description provided.